Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Sinon imports to API docs. #1044

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Conversation

HunterEl
Copy link
Contributor

GOAL:
I was reading through the API documentation and noticed that there were a few inconsistencies with imports of sinon and usage. I have added the explicit imports of sinon to the relevant places in the documentation. I believe this is a valuable addition because it will remove any ambiguity from the code examples.

CURRENT:
Currently, there are a couple of API docs where code examples are using sinon without an explicit import. The main docs page explicitly imports sinon and this change will make it consistent throughout all the docs.

IMPACT:
This will remove ambiguity from the docs and explicitly mention other dependencies for the code samples.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@ljharb ljharb added the docs label Jul 24, 2017
@ljharb ljharb merged commit 8f0b7cd into enzymejs:master Jul 24, 2017
@ljharb ljharb mentioned this pull request Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants