Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link of "life of a request" #14097

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Update link of "life of a request" #14097

merged 2 commits into from
Nov 23, 2020

Conversation

mk46
Copy link
Contributor

@mk46 mk46 commented Nov 19, 2020

Signed-off-by: Manish Kumar manish.kumar1@india.nec.com

Commit Message: Updated link of "life of a request" in STYLE.md
Additional Description: Updated link of "life of a request" in STYLE.md. Currently redirecting to 404.
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #13397

Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
phlax
phlax previously approved these changes Nov 19, 2020
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks @mk46

i think this is the second correction of this link ive seen. im wondering if there are any more/similar

@mk46
Copy link
Contributor Author

mk46 commented Nov 19, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14097 (comment) was created by @mk46.

see: more, trace.

@htuch
Copy link
Member

htuch commented Nov 20, 2020

Thanks. Grep says there is another in PULL_REQUESTS.md, so if you could fix that in this PR it'd be great, thanks!

Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@mk46
Copy link
Contributor Author

mk46 commented Nov 21, 2020

@htuch Thanks for pointing another broken link.

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 90e3148 into envoyproxy:master Nov 23, 2020
qqustc pushed a commit to qqustc/envoy that referenced this pull request Nov 24, 2020
Updated link of "life of a request" in STYLE.md. Currently redirecting to 404.

Fixes envoyproxy#13397

Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
Signed-off-by: Qin Qin <qqin@google.com>
@mk46 mk46 deleted the docs_update branch March 17, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc update: "life of a request"
3 participants