-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update link of "life of a request" #14097
Conversation
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks @mk46
i think this is the second correction of this link ive seen. im wondering if there are any more/similar
/retest |
Retrying Azure Pipelines: |
Thanks. Grep says there is another in |
Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com>
@htuch Thanks for pointing another broken link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Updated link of "life of a request" in STYLE.md. Currently redirecting to 404. Fixes envoyproxy#13397 Signed-off-by: Manish Kumar <manish.kumar1@india.nec.com> Signed-off-by: Qin Qin <qqin@google.com>
Signed-off-by: Manish Kumar manish.kumar1@india.nec.com
Commit Message: Updated link of "life of a request" in
STYLE.md
Additional Description: Updated link of "life of a request" in
STYLE.md
. Currently redirecting to 404.Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #13397