New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/5753 #615

Merged

Tnks2U merged 2 commits into develop-hw from issue/5753

Feb 21, 2023

Contributor

Tnks2U commented Feb 7, 2023

https://oss.navercorp.com/entry/entry2/issues/5753
renderer 리스너가 올려지기 전에 main에서 이벤트를 디스패치하는 경우가 있어서 수정하였습니다.
renderer에서 listen하고 main에서 먼저 ipc 요청을 보내는 방식에서 => renderer 에서 먼저 invoke하고 main의 ipcMain이 handle하도록 수정

Tnks2U added 2 commits

February 7, 2023 17:00


          fix: valide check 타이밍 수정

bef541c


          refactor: 미사용 코드 제거, boolean 의미 반전

e2e16e3

- invalidAsarFile => isValidAsarFile로 수정하고 boolean 의미 반전

Tnks2U requested review from kimorkim, leunge and prisml

February 7, 2023 09:31

Tnks2U merged commit 126e346 into develop-hw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet