Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire Range updated event when data sources are set to empty #900

Merged
merged 1 commit into from
May 16, 2023
Merged

Fire Range updated event when data sources are set to empty #900

merged 1 commit into from
May 16, 2023

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented May 12, 2023 •
edited
Loading

The updated event on a DataRange1D was not being fired when the last data source was removed. This fixes that.

Fixes #821

@corranwebster corranwebster changed the title Fire updated event when data sources are set to empty Fire Range updated event when data sources are set to empty May 12, 2023
dpinte
dpinte approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@dpinte dpinte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@corranwebster corranwebster merged commit 30be22c into main May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpinte dpinte dpinte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing a data source makes DataView objects inconsistent
2 participants
@corranwebster @dpinte