Fix LegendHiglighter hit detection
#897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes Legend.get_label_at() to return the entire legend label region, including icon, which then allows LegendHightlighter to use the actual mouse position to perform it's hit detection.
corranwebster
commented
May 12, 2023
| @@ -427,7 +427,7 @@ def get_preferred_size(self): | |||
| # We need a dummy GC in order to get font metrics | |||
| dummy_gc = font_metrics_provider() | |||
| label_sizes = array( | |||
| [label.get_width_height(dummy_gc) for label in labels] | |||
| [label.get_bounding_box(dummy_gc) for label in labels] | |||
There was a problem hiding this comment.
This will correctly handle labels at an angle..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
Legend.get_label_at()to return the entire legend label region, including icon, which then allowsLegendHightlighterto use the actual mouse position to perform it's hit detection.Fixes #825