Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use traitsui.api as tui #634

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Dont use traitsui.api as tui #634

merged 1 commit into from
Apr 8, 2021

Conversation

aaronayres35
Copy link
Contributor

fixes #611

This PR simply imports the needed objects from traitsui.api rather than importing the whole thing as tui.

As a side note, this module is based around Workbench which has been deprecated in favor of tasks. Perhaps we want to rewrite this module? Or deprecate, or remove it... 🤔

@aaronayres35 aaronayres35 requested a review from rahulporuri April 8, 2021 12:07
rahulporuri
rahulporuri approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm on board with removing it entirely but let's do later, after we've discussed it with the rest of the folks.

@aaronayres35 aaronayres35 merged commit 4b4b648 into master Apr 8, 2021
@aaronayres35 aaronayres35 deleted the remove-tui branch April 8, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dont use traitsui.api as tui
2 participants
@aaronayres35 @rahulporuri