Allow required false and default #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 20, 2016 17:07
Added tests for using default when default is callable. Fixed field get_attribute(), now uses get_default() instead of default.
|
On a sidenote: What's the policy on using pytest? I see quite some pytest constructs being used ( The tests added here can probably benefit from using parameters, so I'd be glad to add that. |
|
Looks good to me, yes! Tho let's hold it to the next major release since it changes the behavior. |
Probably just to use py.test's canonical style wherever possible. More than happy to review further changes to bring us more into line there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue described in #2785.
When serializing an dict or object, now the default value is used if the key or attribute is missing from the dict or object. Previously a KeyError or AttributeError was raised.
Two tests failed after implementing the change, which was to be expected as they specifically targeted the behaviour of key or attribute being required even if default is set for the field (serializers.py, TestNotRequiredOutput).
They have been replaced by tests targeting the use of defaults when key or attribute is not present in the instance.
Deserialization seems unaffected.
What isn't clear to me is what the rationale was of explicitly requiring the instance key/attribute to be present, even if a default is provided, so I'm wondering if there's a scenario I'm overlooking.