Thanks @cclauss! Good idea.

I think the old flake8 may need to be removed from the config file, as it seems to still be waiting for that in the CI info here.

Also please add yourself to AUTHORS.

Btw, it may be best to run the python2 and 3 tests in a single circleCI job - as it's fast enough, and avoids any constant job overhead.

If we keep them separate, it will be easier to drop Python 2 in ~184 days.

Where exactly are the required vs. optional tests stored? I.E. In which file does the old flake8 need to be removed? Thx.

I added myself to authors in #8876

If we keep them separate, it will be easier to drop Python 2 in ~184 days.

I'm a big fan of the python3 upgrade, and I even opened the bug for that: #7198.

However, I don't think that the ending of upstream support for python2 is going to be the forcing factor here. Emscripten has a complex set of objectives and a diverse set of users. For example we have used on ancient version of OSX who have a system python that is years old already, so we already support customers on unsupported pythons.

So yes, by all means lets work towards removing python2, but I don't see that specific date as the main driver here.

I agree with @kripken.. lets just add it to the existing flake8 job. I think it will actually make removing it easier... or at least the patch will be smaller to remove it.

I think those test errors were temporary breakage from earlier, please merge in latest incoming to here.

Otherwise this looks good to me. I assume the --exit-zero is intentional, as mentioned in the first comment (that is, it is temporary but will exist beyond this one PR)?

To fix the tests, I think we need to merge origin/incoming into here, to get the latest changes there (just re-running tests won't work since it's running the same old code from before, that has been fixed meanwhile in upstream).

Btw, does anyone know if there a way for project maintainers to do such a merge themselves? I've seen other projects have an option "let other people add commits" but I'm not sure how to enable that in this repo.

Oh, it sounds like the PR creator can allow maintainers to add commits, but no one else, https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork So that might not help us much it still requires a manual step for PR submitters for us to help merge incoming in. But whatever people prefer to do is fine with me.

144 days until Python 2 end of life.

1     E211 whitespace before '('
55    E722 do not use bare 'except'
10    E741 ambiguous variable name 'l'
3     E999 SyntaxError: invalid syntax
6     F632 use ==/!= to compare str, bytes, and int literals
5     F821 undefined name 'xrange'
3     F841 local variable 'e' is assigned to but never used
40    W504 line break after binary operator
97    W605 invalid escape sequence '\s'
7     W606 'async' and 'await' are reserved keywords starting with Python 3.7

The E999 syntax errors must be fixed to be Python 3 compatible. #9200 and #9201
The W606 errors must be fixed to be Python >= 3.7 compatible.
The F821 errors are worthy of investigation.
The E722 issues are described at https://realpython.com/the-most-diabolical-python-antipattern