Switch the #! lines in all .py files to python3 #10357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one step towards using python3 by default everywhere. Notably: - python2 is still fully supported at this point - The top level scripts such as `emcc` as opposed to `emcc.py` are still run under just "python" so will work with whatever the system default is. This is because we still want to run on the default OSX install which doesn't python3 installed (and probably never will). Also: - switch circleci testing on linux to python2 - Update some docs that refer to python2 See #7198
|
by "doesn't python3 installed" you mean that osx will never have a binary named 'python3'? Or OSX will never have python3, and the user will have to install it themselves? |
I mean python3 is not part of the OS base image. |
kripken
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one step towards using python3 by default everywhere.
Notably:
emccas opposed toemcc.pyarestill run under just "python" so will work with whatever the system
default is. This is because we still want to run on the default OSX
install which doesn't python3 installed (and probably never will).
Also:
See #7198