Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGPL-licensed freealut misrepresented as part of emscripten #12711

Closed
jonassmedegaard opened this issue Nov 5, 2020 · 1 comment · Fixed by #12712
Closed

LGPL-licensed freealut misrepresented as part of emscripten #12711

jonassmedegaard opened this issue Nov 5, 2020 · 1 comment · Fixed by #12712

Comments

@jonassmedegaard
Copy link

Main code files below tests/third_party/freealut contain the standard emscripten copyright boilerplate referring to LICENSE file for licensing, despite a) file tests/third_party/freealut/README stating an LGPL license, and b) file LICENSE not covering LGPL.

The file LICENSEdoes at the end make a loose exception for for "The third_party/ subdirectory" which arguably also covers tests/third-party files, but then it does not make sense to add that standard boilerplate.

Please either clarify more explicitly the relationship between LGPL licensing and Emscripten copyright for freealut code files, or simply remove that boilerplate if it was applied in error.
sbc100 added a commit that referenced this issue Nov 5, 2020
@sbc100
Remove emscripten copyright from third_party headers
3538b51 
Its seems we painted with too broad a brush in #7116.

This change was generated programmatically using this type of thing:

for f in `git grep --name-only "//.*The Emscripten Authors" tests/third_party`; do tail -n +6 $f > tmp && /bin/mv tmp $f; done

Fixes: #12711
@sbc100 sbc100 mentioned this issue Nov 5, 2020
Merged
@sbc100
Copy link
Collaborator

sbc100 commented Nov 5, 2020

Thanks! It looks like #7116 was look overzealous and didn't take into account third party code in the test directory.

sbc100 added a commit that referenced this issue Nov 5, 2020
@sbc100
Remove emscripten copyright from third_party headers (#12712)
dcd3854 
Its seems we painted with too broad a brush in #7116.

This change was generated programmatically using this type of thing:

for f in `git grep --name-only "//.*The Emscripten Authors" tests/third_party`; do tail -n +6 $f > tmp && /bin/mv tmp $f; done

Fixes: #12711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove emscripten copyright from third_party headers emscripten-core/emscripten
2 participants
@sbc100 @jonassmedegaard