Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak babel.md #656

Merged
merged 1 commit into from
May 14, 2018
Merged

Tweak babel.md #656

merged 1 commit into from
May 14, 2018

Conversation

smhutch
Copy link
Contributor

@smhutch smhutch commented May 13, 2018

What:
Content change in babel.md.

Why:
To avoid ambiguous language. When reading babel.md, I misunderstood:

but not required in version 8 and above

as:

but you don't need to install it to get the additional features in version 8 and above.

How:
Explicitly state that installation is optional in version 8 and above.

Checklist:

  • Documentation
  • Tests N/A
  • Code complete N/A

I'm looking to get into helping with open-source projects I use, this is the first opportunity I have found to hopefully help. Really enjoying emotion so far 😄

@ChristopherBiscardi
Copy link
Member

Awesome :) You might be interested in #655 too

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit 9877c68 into emotion-js:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants