Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for object arguments in css prop with source maps #332

Merged
merged 8 commits into from
Sep 25, 2017

Conversation

tkh44
Copy link
Member

@tkh44 tkh44 commented Sep 24, 2017

What:
Add source map support to css prop that uses objects

Why:
it didn't work

How:
Add sourcemaps in the the one situation that didn't work.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@tkh44 tkh44 requested a review from emmatown September 24, 2017 19:45
@codecov
Copy link

codecov bot commented Sep 24, 2017

Codecov Report

Merging #332 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   97.27%   97.29%   +0.01%     
==========================================
  Files          17       17              
  Lines         551      555       +4     
  Branches      130      132       +2     
==========================================
+ Hits          536      540       +4     
  Misses         11       11              
  Partials        4        4
Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/css-prop.js 100% <100%> (ø) ⬆️
packages/emotion/src/index.js 100% <100%> (ø) ⬆️
packages/babel-plugin-emotion/src/index.js 94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb383f4...516fecd. Read the comment docs.

@emmatown emmatown merged commit 8ff5264 into master Sep 25, 2017
@emmatown emmatown deleted the css-object-prop-source-map-support branch September 25, 2017 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants