Stylis upgrade #2590
Stylis upgrade #2590
Conversation
🦋 Changeset detectedLatest commit: 7c3324d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/cache/src/stylis-plugins.js
Outdated
| if ( | ||
| // @media | ||
| parent.type.charCodeAt(1) !== 109 && | ||
| // @supports | ||
| parent.type.charCodeAt(1) !== 115 | ||
| ) { | ||
| return | ||
| } |
There was a problem hiding this comment.
This was a fix for stylis@4.0.11 that was out briefly but Sultan has patched the "regression" in a timely manner, and released stylis@4.0.12. So I've decided not to include this fix.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7c3324d:
|
Codecov Report
|
| !element.length | ||
| // positive .length indicates that this rule contains pseudo | ||
| // negative .length indicates that this rule has been already prefixed | ||
| element.length < 1 |
There was a problem hiding this comment.
this fixes prefixed rules (like .css-hash::-webkit-input-placeholder {}) - with the latest stylis@4.0.11 and stylis@4.0.12 those were replaced with their non-prefixed versions
There was a problem hiding this comment.
Is stylis's prefixing of ::-webkit-input-placeholder incorrect as it stands?
There was a problem hiding this comment.
No, its prefixing it alright - we were screwing up the prefixed rules here though, before this change
packages/cache/package.json
Outdated
| @@ -19,7 +19,7 @@ | |||
| "@emotion/sheet": "^1.1.0", | |||
| "@emotion/utils": "^1.0.0", | |||
| "@emotion/weak-memoize": "^0.2.5", | |||
| "stylis": "^4.0.10" | |||
| "stylis": "4.0.12" | |||
There was a problem hiding this comment.
I've decided to pin the version of this dependency as it's super crucial for Emotion and changes to it can affect our code in subtle ways. We want to keep this up-to-date with every release of Stylis - but we should always verify that our test suite passes before we can bump this dependency range
FYI @thysultan - this is what i've ended up with as to changes introduced to accommodate 4.0.12. I've decided to ignore 4.0.11 and removed the fix that I had for it ( 26b3e2d ) since that version was out only briefly and we didn't actually get any bug reports about this.