Fix model parsing for Boolector 3.2.2 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Boolector release [changed][] the format of SMT models to conform to the SMT-LIB spec by not including the `model` symbol, which our parser was expecting (mostly because that's what Z3 does). It's not hard to support both versions, so let's do that. [changed]: Boolector/boolector@5c862bc
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Boolector release changed the format of SMT models to conform
to the SMT-LIB spec by not including the
modelsymbol, which ourparser was expecting (mostly because that's what Z3 does). It's not hard
to support both versions, so let's do that.
Tested by running the Rosette tests with both Boolector v3.2.1 and v3.2.2.