Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client for error tracer #156

Merged
merged 5 commits into from
May 15, 2020
Merged

Client for error tracer #156

merged 5 commits into from
May 15, 2020

Conversation

sorawee
Copy link
Collaborator

@sorawee sorawee commented May 12, 2020

No description provided.

jamesbornholt
jamesbornholt reviewed May 13, 2020
View reviewed changes
Copy link
Collaborator

@jamesbornholt jamesbornholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor comments.

rosette/lib/util/server.rkt Outdated Show resolved Hide resolved
rosette/lib/util/ws-server.rkt Outdated Show resolved Hide resolved
rosette/lib/util/server.rkt Outdated Show resolved Hide resolved
rosette/lib/trace/raco.rkt Outdated Show resolved Hide resolved
@emina emina merged commit a3df4f9 into emina:master May 15, 2020
@emina
Copy link
Owner

emina commented May 15, 2020

Cool; thank you!

@sorawee sorawee deleted the error-tracer-client branch May 15, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbornholt jamesbornholt jamesbornholt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorawee @emina @jamesbornholt