Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delphi port #142

Merged
merged 4 commits into from
Jan 20, 2020
Merged

Add Delphi port #142

merged 4 commits into from
Jan 20, 2020

Conversation

rhatherall
Copy link
Contributor

Adds port using Delphi 10.3 with DUnitX.

@emilybache
Copy link
Owner

Thanks for this! You've included two binary files both '.res'. They appear to be test result files? Are they built from the unit test source code you've added? Can you tell me why these need to be included in the repo starting position?

@rhatherall
Copy link
Contributor Author

No probs, thank you :)

Delphi automatically creates Windows resource files for each project. They contain information regarding things like platform support, icons, build information such as versions and build numbers. The files included here are vanilla files that will be recreated when the projects are built for the first time. I am happy to remove them and add to the .gitignore, if you prefer, as it will have no real impact on the usability of the project.

@emilybache
Copy link
Owner

I think it would be good to not include files that the user can easily re-create for themselves. This repo is quite large already! If it's not too much trouble could you fix that?

@rhatherall
Copy link
Contributor Author

No problems. Done.

@emilybache emilybache merged commit 1cd3ba5 into emilybache:master Jan 20, 2020
@emilybache
Copy link
Owner

Thankyou!

lroberts77 pushed a commit to lroberts77/GildedRose-Refactoring-Kata that referenced this pull request Jul 3, 2020
aflori added a commit to aflori/GildedRose-Refactoring-Kata that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants