Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL/pg SQL: improve README (add requirements) / Add unit test framework (pgTAP) #136

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Conversation

GradedJestRisk
Copy link
Contributor

This PR includes 2 commits, one for each feature, and can be split if appropriate.
The transaction validation (COMMIT) in update_quality.sql has been removed to enable tests to be deterministic.

@fpellet
Copy link
Contributor

fpellet commented Dec 23, 2019

😃 Same idea
In parallel, I also made a postgres version (#137 ). I just saw that you proposed one.
My version already contains the setup.
Does it suit you?

@fpellet
Copy link
Contributor

fpellet commented Dec 28, 2019

I moved my code in plpgsql/pgunit
Can you move your code in plpgsql/pgtap ?

There is an error on line 71 of code/update_quality.sql. Several product can have same name.

@GradedJestRisk
Copy link
Contributor Author

PR updated to make way to pgUnit PR 137

@emilybache
Copy link
Owner

Hello, thankyou so much for your pull request. I see you are also contributing to the other pull request for a postgres sql version of this kata. Would you like me to accept both pull requests, or can you come up with one request between you?

@emilybache emilybache merged commit c61a88a into emilybache:master Jan 7, 2020
@emilybache
Copy link
Owner

Thankyou!

lroberts77 pushed a commit to lroberts77/GildedRose-Refactoring-Kata that referenced this pull request Jul 3, 2020
PL/pg SQL: improve README (add requirements) / Add unit test framework (pgTAP)
aflori added a commit to aflori/GildedRose-Refactoring-Kata that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants