-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip type normalization #8
Conversation
👍 |
|
Valid point, I'm going to update it to dasherized syntax asap. Though that doesn't change the fact that normalization is currently inconsistent. Type is sometimes being normalized and sometimes not. |
i sorta want to move to a very strict resolver, that basically throws an error if it gets some invalid name. Rather then doing most of the normalizing. Although I am not sure if this is just going to be annoying for people |
Is there any chance that this can be merged in for now, just while we move towards a more strict resolver? This PR makes the data portion of the Ember Inspector work with Ember App Kit. I'm coming over to EAK after using Yeoman mainly and this was a bit of a surprise. I'm a HUGE fan of EAK otherwise. Everything just makes sense. |
sounds good for now. We must fix our internal (ember-data and ember's) incorrect naming conventions asap though. |
Any chance we could get this change pushed to |
@WMeldon - I just checked, and I believe that the latest changes are reflected in |
@rjackson Just ran a |
Do we need to update the chrome extension to a newer version or from master? I'm currently on 0.0.6 and I did |
@adimitri we are still working to fix this. @lukemelia and myself discussed this last night, and he has begun a fix. We hope to have it out in the wild soon. |
add `testem` to run tests more easily.
Since we cannot normalize a standalone type, type injections are not normalized. However types are being normalized on registration. This causes a mismatch between the type for injection and the registered type.
For example:
container.register('dataAdapter:main')
gets registered asdata-adapter:main
, butcontainer.injection('dataAdapter', 'store', 'store:main')
injects intodataAdapter
and notdata-adapter
.