Don't log if logging is disabled #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running into this at the moment |
|
tests please |
|
@stefanpenner on their way, would you prefer the guard in the |
|
@rlivsey all of logLookup should be guarded. |
|
Ok, updated & added some tests. The tests just check to see whether anything was logged at all, not their content, which I hope is sufficient for this specific pull request. |
| @@ -200,12 +200,14 @@ define("ember/resolver", | |||
| } | |||
|
|
|||
| if (tmpModuleName && moduleEntries[tmpModuleName]) { | |||
| self._logLookup(true, parsedName, tmpModuleName); | |||
| if (!loggingDisabled) { | |||
There was a problem hiding this comment.
where does findModuleName get called other then lookupDescription
stefanpenner
added a commit
that referenced
this pull request
Jun 3, 2014
Don't log if logging is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this guard was in the logging method itself, should it be moved back there instead?