Added config type to module unification config #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday I raised ember-fastboot/ember-cli-fastboot#596, where a combination of using ember-cli-fastboot with module unification caused this error when running the server.
Error: Assertion Failed: 'config' is not a recognized type@rwjblue suggested creating this PR to solve the issues of a missing type.
The changes I've made certainly solves the issue I had and my module unification example app with fastboot now renders.
Having said that I have no idea if my idea to create a
typeanddefinitiveCollectionand then make that unresolvable (copied fromutilsapproach) is the correct solution with no unintended side-effects.