-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strip Ember.assert
calls from production output
#5680
Comments
This isn't an ember cli issue. Likely an ember-data one |
@stefanpenner It isn't just ember-data, |
@GavinJoyce that isn't a feature ember-cli ships with though, which is expected IMHO, if someone wants to add that by default an RFC + champion might be in-order. http://emberjs.com/api/#method_assert I suspect refers to embers own build tools |
@stefanpenner thanks, I'll create a PR to update the docs and create an addon to do the stripping |
@GavinJoyce sweet, i do think it may be reasonable to actually bundle this stripping by defaul \w all apps and addonst. I believe the best solution would be for it to be part of the existing babel transform, merely as a plugin. Obvious the devil is in the details, and will likely need some massaging, but it may be worth it . |
Reopening after discussion in ember-cli core team meeting today. |
@rwjblue I would prefer to transition this to an RFC, as it needs fleshing out. |
@stefanpenner - I agree. @GavinJoyce - I think that we (ember-cli core) are all on board and want this feature, but it needs to go through an RFC process first. If you have some time, I'd love to setup some time to review the various parts of the RFC and make a plan for implementation (which I suspect is fairly straightforward actually). |
@rwjblue sure, let's do that. I'm happy to bring this to completion once we've chatted |
I had a quick chat with @rwjblue, I'll submit an RFC within the next few days |
Sweet. Im going to close this issue then, we can revisit as an RFC, flesh it out, then transition to the implementation plan. |
Here's the RFC: ember-cli/rfcs#50 |
According to the docs,
Ember.assert
calls should be removed from the production build output. This doesn't seem to be the case.Here's some discussion: https://embercommunity.slack.com/archives/ember-cli/p1458857451000785
The text was updated successfully, but these errors were encountered: