std example cosmetics #3702
Merged
std example cosmetics #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartMassey
force-pushed
the
std-example-cosmetics
branch
from
98b6d98 to
76bc7ed
Compare
Dirbaio
reviewed
Jan 1, 2025
examples/std/src/bin/net.rs
Outdated
|
|
||
| /// In a `no_std` situation it is useful to be able to | ||
| /// format into a fixed-size buffer using the | ||
| /// `core::fmt::write` macro. This struct enables that. |
There was a problem hiding this comment.
this is a bit too complex for an example, i'd suggest using heapless::String instead. you can write! into it just like WriteBuf.
(or just give up on nostd and use format!, since this example is for std. I do think it's nice to keep things copypastable to nostd code tho)
There was a problem hiding this comment.
Doh. Hadn't noticed we were already depending on heapless and was trying to avoid it. Thanks for the catch. Fixed.
BartMassey
force-pushed
the
std-example-cosmetics
branch
from
76bc7ed to
b5ef53a
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some minor cosmetic cleanups to the README and demo in
examples/std.