Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Filter lenses that are not visible without converting to Posi… #4073

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

iitalics
Copy link
Contributor

@iitalics iitalics commented Jun 14, 2023

…tion"

This reverts commit 18c94fa. (#4065)

The use of lsp--point-to-position is not correct since there appears to be a lot of unfinished work regarding the use of the Position structure. currently this function always returns a plist and a lot of other code depends on this fact:

in order to write lsp-lens--window-range like this, further refactoring work needs to be finished

@yyoncho yyoncho enabled auto-merge (squash) June 14, 2023 18:38
@yyoncho yyoncho merged commit 448a2fd into emacs-lsp:master Jun 14, 2023
@iitalics iitalics deleted the iitalics/revert-lenses-position branch June 14, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants