Don't block within lsp-request-while-no-input #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocking seems to be at odds with the function name, and can be annoying if the language server fails to respond to a completion request (which is currently the only request handled by `lsp-request-while-no-input`). To restore the former behavior (of having lsp-request-while-no-input block whenever non-essential is nil), set the newly introduced defcustom `lsp-request-while-no-input-may-block` to t.
yyoncho
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-request-while-no-inputcurrently may block (ifnon-essentialis set tonil), which seems to be both at odds with the function name itself, and can be very annoying when called during autocompletion (which AFAICT, is currently the only user oflsp-request-while-no-input). With this PR,lsp-request-while-no-inputwill always abort on user input. If desired, the former behavior can be restored by setting the newly introduced defcustomlsp-request-while-no-input-may-blocktot.