Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lsp-defcustom #4040

Merged
merged 1 commit into from
May 3, 2023
Merged

Introduce lsp-defcustom #4040

merged 1 commit into from
May 3, 2023

Conversation

yyoncho
Copy link
Member

@yyoncho yyoncho commented May 3, 2023

  • we used defcustom-lsp due to formatting. Now the new version of elisp
    formatter works fine

@yyoncho
Introduce lsp-defcustom
65b1cea 
- we used `defcustom-lsp` due to formatting. Now the new version of elisp
formatter works fine
@github-actions github-actions bot added client One or more of lsp-mode language clients documentation labels May 3, 2023
@yyoncho yyoncho enabled auto-merge (squash) May 3, 2023 10:17
@yyoncho yyoncho disabled auto-merge May 3, 2023 10:17
@yyoncho yyoncho merged commit bbed1bd into emacs-lsp:master May 3, 2023
@ericdallo
Copy link
Member

nice!

@sr9992
Copy link

sr9992 commented May 5, 2023

I just pulled this update, and I can't start LSP anymore:

Error running timer: (void-variable lsp-ada-project-file)
...
require: Symbol’s value as variable is void: lsp-ada-project-file

I don't use ada at all. I run (lsp-deferred) in my C++ mode hook. Any thoughts as to what I'm doing wrong? Using Emacs 27.1.

@sr9992
Copy link

sr9992 commented May 5, 2023

Never mind, clearing out some .elc files seemed to get it working again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yyoncho @ericdallo @sr9992