Re-evaluate ccls-library-folders-fn
#123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaskRay
reviewed
Jan 24, 2024
ccls.el
Outdated
| @@ -164,7 +164,7 @@ DIRECTION can be \"D\", \"L\", \"R\" or \"U\"." | |||
| (lsp-ht ("$ccls/publishSkippedRanges" #'ccls--publish-skipped-ranges) | |||
| ("$ccls/publishSemanticHighlight" #'ccls--publish-semantic-highlight)) | |||
| :initialization-options (lambda () ccls-initialization-options) | |||
| :library-folders-fn ccls-library-folders-fn)) | |||
| :library-folders-fn (lambda (&rest args) (apply ccls-library-folders-fn args)))) | |||
There was a problem hiding this comment.
Seems correct, but I haven't updated my emacs config for a long time and have mostly forgotten elisp :(
There was a problem hiding this comment.
I noticed that this could crash if ccls-library-folders-fn is nil, posted a fix.
MaskRay
approved these changes
Jan 24, 2024
Customizing the variable `ccls-library-folders-fn` did not do anything, because the variable is evaluated once when the package loads. That occurs even before `custom.el` runs. This replaces the bare reference with a wrapper lambda that will pick up a new value of the variable.
yyoncho
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizing the variable
ccls-library-folders-fndid not do anything, because the variable is evaluated once when the package loads. That occurs even beforecustom.elruns. This replaces the bare reference with a wrapper lambda that will pick up a new value of the variable.