Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse-1 on 'N refs' #115

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Fix mouse-1 on 'N refs' #115

merged 3 commits into from
Jan 11, 2023

Conversation

JohnC32
Copy link

@JohnC32 JohnC32 commented Dec 9, 2022

Fix a few issues

John Ciolfi added 3 commits December 9, 2022 14:44
Using Emacs 27 on Linux, prior to this commit, when clicking on the 'N refs' annotation created by
code lens, you would get "cl--assertion-failed: Assertion failed: (functionp fetcher)".

The issue is in ccls.el, lsp-execute-command which was calling xref--show-xrefs when it should
have been calling lsp-show-xrefs. I also fixed a similar issue in ccls-code-lens.el.

See emacs-lsp/lsp-mode#3838
Prior to this fix, when using ccls-member-hierarchy, followed by a mouse-1 clicking in the member
hierarchy view, you'll see:

     Debugger entered--Lisp error: (void-variable cur-buffer-workspaces)
       ccls-tree-press()
       ccls-tree-press-and-switch()
       funcall-interactively(ccls-tree-press-and-switch)
       call-interactively(ccls-tree-press-and-switch nil nil)
       command-execute(ccls-tree-press-and-switch)
There's still two left (on Emacs 27):

    ccls-inheritance-hierarchy.el:49:1:Warning: Unused lexical variable ‘children’
    ccls.el:153:27:Warning: Unused lexical argument ‘command’

Not sure what the right fix is for these (is it incomplete code?)
@JohnC32
Copy link
Author

JohnC32 commented Jan 11, 2023

Is there something I should do to have the changes pulled into ccls master (perhaps I'm not using github correctly as I don't regularly use it?)

@yyoncho yyoncho merged commit 29d2315 into emacs-lsp:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants