Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor contributor page #809

Merged
merged 40 commits into from
Dec 12, 2024
Merged

fix: refactor contributor page #809

merged 40 commits into from
Dec 12, 2024

Conversation

tcm390
Copy link
Collaborator

@tcm390 tcm390 commented Dec 3, 2024

Relates to:

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

@tcm390 tcm390 marked this pull request as draft December 3, 2024 03:48
@madjin
Copy link
Collaborator

madjin commented Dec 3, 2024

nice looks like it's auto-updating the github contributor page now

image

@madjin
Copy link
Collaborator

madjin commented Dec 3, 2024

dark mode fixed and looks good
image
image

@madjin madjin changed the title refactor contributor page fix: refactor contributor page Dec 3, 2024
@madjin
Copy link
Collaborator

madjin commented Dec 8, 2024

okay it looks good but wondering if we can do more than 2 columns
image

and if we can fetch the data from https://ai16z.github.io/data/contributors.json

@lalalune
Copy link
Member

Good to go?

Copy link
Collaborator

@madjin madjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall everything looks good, we just need to add an .env variable / modify this access token variable in repo settings as specified in the docusaurus.config.js

@madjin
Copy link
Collaborator

madjin commented Dec 12, 2024

what if we had a workflow to update docs when pushing to docs branch?

name: Deploy Docs

on:
  push:
    branches:
      - docs
  workflow_dispatch:

permissions:
  contents: write

jobs:
  deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

      - uses: pnpm/action-setup@v3
        with:
          version: 9.4.0

      - uses: actions/setup-node@v4
        with:
          node-version: "23"
          cache: "pnpm"

      - name: Install dependencies
        run: pnpm install --no-frozen-lockfile

      # Add the environment variable mapping here
      - name: Build website
        env:
          GITHUB_ACCESS_TOKEN: ${{ secrets.GH_TOKEN }}
        run: pnpm run build

      - name: Deploy to GitHub Pages
        uses: peaceiris/actions-gh-pages@v3
        with:
          github_token: ${{ secrets.GH_TOKEN }}
          publish_dir: ./build
          user_name: github-actions[bot]
          user_email: 41898282+github-actions[bot]@users.noreply.github.com
          ```

@tcm390 tcm390 marked this pull request as ready for review December 12, 2024 21:57
@tcm390 tcm390 changed the base branch from main to develop December 12, 2024 22:04
@madjin madjin merged commit 7ad74e3 into develop Dec 12, 2024
6 checks passed
@madjin madjin deleted the tcm-contributor-page branch December 12, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants