Update basic auth docs #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
commented
Mar 4, 2020
| @@ -14,7 +14,7 @@ defmodule Plug.BasicAuth do | |||
| import Plug.BasicAuth | |||
| plug :basic_auth, username: "hello", password: "secret" | |||
|
|
|||
| Or if you would rather put those in an environment variable: | |||
| Or if you would rather put those in a config file: | |||
There was a problem hiding this comment.
I was on a fence here, now this section seems redundant to the section above, but if we're gonna use env variables we should use a different approach as they should be read at runtime.
There was a problem hiding this comment.
I meant to say app env. Good catch.
josevalim
reviewed
Mar 4, 2020
| @@ -33,13 +33,15 @@ defmodule Plug.BasicAuth do | |||
| If you want to provide your own authentication logic on top of | |||
| Basic HTTP auth, you can use the low-level functions. For example: | |||
|
|
|||
| import Plug.BasicAuth | |||
| plug :auth | |||
|
|
|||
There was a problem hiding this comment.
We need to say then they can define their own plug, giving a bit more of context to what we are doing
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.