Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script_name accumulation during forward #172

Merged
merged 1 commit into from
Jan 26, 2015

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jan 26, 2015

Previously, the order of path segments was reversed

Previously, the order of path segments was reversed
yrashk referenced this pull request in kbrw/ewebmachine Jan 26, 2015
josevalim added a commit that referenced this pull request Jan 26, 2015
Fix script_name accumulation during forward
@josevalim josevalim merged commit d17bd02 into elixir-plug:master Jan 26, 2015
@awetzel
Copy link
Contributor

awetzel commented Jan 26, 2015

you solved one of my application bug Yurii :), actually when you are into this, the documentation about script_name is missing. Actually the only information in the plug module is in the full_path func documentation, and it refers to the wrong name (script_path).

https://github.com/elixir-lang/plug/blob/master/lib/plug/conn.ex#L180

@josevalim
Copy link
Member

@awetzel can you please send a pull request for improving the docs? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants