Proxy settings fixes #285
Merged
Proxy settings fixes #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galeksandrp
force-pushed
the
socks-hostname-resolve
branch
4 times, most recently
from
8985378 to
090b8d1
Compare
galeksandrp
force-pushed
the
socks-hostname-resolve
branch
4 times, most recently
from
bd39dcf to
c236c63
Compare
|
@galeksandrp Was that testes with Kodi 17/18? |
galeksandrp
force-pushed
the
socks-hostname-resolve
branch
from
c236c63 to
04aaf27
Compare
|
antonsoroko
reviewed
May 22, 2021
| @@ -244,7 +244,7 @@ msgid "Use proxy settings" | |||
| msgstr "" | |||
|
|
|||
| msgctxt "#32107" | |||
| msgid "Proxy from Elementum settings" | |||
| msgid "From Elementum settings" | |||
There was a problem hiding this comment.
@galeksandrp
since you changed template - you also need to change all translated files, otherwise the will lose old translation after running synchronization scripts in scripts dir.
for file in resources/language/*/*.po; do sed -i 's/msgid "Proxy from Elementum settings"/msgid "From Elementum settings"/' "$file"; done
will do the trick.
galeksandrp
force-pushed
the
socks-hostname-resolve
branch
from
04aaf27 to
182ec63
Compare
|
@galeksandrp please, run Is this finished? Working as expected? |
|
@galeksandrp ping |
- Fixes `Proxy from Elementum settings` setting Log reported setting applied without really doing anything. - Adds `Proxy from Elementum (resolve hosts by proxy)` setting option Option enables default behaviour of `Elementum` in `Burst`. Option is set as new default, existing users should not be affected by change. - Adds choice of additional proxy protocols in settings `SOCKS4a` (`SOCKS4` latest version with hostname resolve by proxy) `SOCKS5h` (`SOCKS5` latest version with hostname resolve by proxy). Protocol is set as new default to match default setting in `Elementum`, existing users should not be affected by change. - Adds help label for `use_elementum_proxy` setting
galeksandrp
force-pushed
the
socks-hostname-resolve
branch
from
79508f8 to
74f4722
Compare
1. ./scripts/xgettext.sh EXIT CODE 0 2. ./scripts/xgettext_merge.sh EXIT CODE 0
./scripts/xgettext.sh ALL OK./scripts/xgettext_merge.sh ALL OKI am committed files changed by Technically I should redo manual testing from #285 (comment), but I can't do that earlier than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy from Elementum settingssettingLog reported setting applied without really doing anything.
Proxy from Elementum (resolve hosts by proxy)setting optionOption enables default behaviour of
ElementuminBurst. Option is set as new default,existing users should not be affected by change.
SOCKS4a(SOCKS4latest version with hostname resolve by proxy)SOCKS5h(SOCKS5latest version with hostname resolve by proxy). Protocol is set as newdefault to match default setting in
Elementum, existing users should not be affected bychange.
use_elementum_proxysetting