Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [statistic] fix excessive decimals when value is NAN #17798

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix(components): [statistic] fix excessive decimals when value is NAN #17798

merged 1 commit into from
Aug 8, 2024

Conversation

tuskermanshu
Copy link
Contributor

When the value is NAN, correct the display issue that shows unnecessary decimal points.

closed #17784

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@tuskermanshu
fix(components): [statistic]Fix excessive decimals when value is NAN
a9fbe20 
When the value is NAN, correct the display issue that shows unnecessary decimal points.

closed element-plus#17784
@pull-request-triage Pull Request Triage
Copy link

👋 @dadaguai-git, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Hello @dadaguai-git, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🧪 Playground Preview: https://element-plus.run/?pr=17798
Please comment the example via this playground if needed.

@tuskermanshu
Copy link
Contributor Author

Playground

@btea btea changed the title fix(components): [statistic]Fix excessive decimals when value is NAN fix(components): [statistic] fix excessive decimals when value is NAN Aug 8, 2024
btea
btea approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 7c9414a into element-plus:dev Aug 8, 2024
11 checks passed
@tuskermanshu tuskermanshu deleted the main branch August 9, 2024 00:59
@element-bot element-bot mentioned this pull request Aug 9, 2024
Merged
3 tasks
@B1u3e B1u3e mentioned this pull request Sep 5, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees

@tuskermanshu tuskermanshu

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [statistic] unexpected decimal 0s added when value is NaN and precision is non-zero value
3 participants
@tuskermanshu @tolking @btea