Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table] fix sorting issue in table-column #17608

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fix(components): [table] fix sorting issue in table-column #17608

merged 1 commit into from
Jul 27, 2024

Conversation

xixiIBN5100
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

issues #17439

@pull-request-triage Pull Request Triage
Copy link

👋 @xixiIBN5100, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Hello @xixiIBN5100, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 21, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=17608
Please comment the example via this playground if needed.

@xixiIBN5100 xixiIBN5100 removed their assignment Jul 22, 2024
@xixiIBN5100
fix(components): fix sorting issue in table-column
ac63eb5 
fix(components): fix sorting issue in table-column

Revert "fix(components): [message-box] vue wraning when button state is loading (#17603)"

This reverts commit ab494bb.

fix(components): fix sorting issue in table-column

Revert "docs(docs): [skeleton] fix layout error in example (#17291)"

This reverts commit 0f86843.

fix(components): fix sorting issue in table-column

fix(components): fix sorting issue in table-column

fix(components): fix sorting issue in table-column
btea
btea approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit b692e37 into element-plus:dev Jul 27, 2024
9 checks passed
@element-bot element-bot mentioned this pull request Aug 9, 2024
Merged
3 tasks
@B1u3e B1u3e mentioned this pull request Sep 5, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 25, 2024
Open
Open
@B1u3e B1u3e mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees
No one assigned
Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xixiIBN5100 @tolking @btea