New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add mention component #17586

Merged

kooriookami merged 20 commits into dev from feat/mention

Aug 2, 2024

Contributor

Fuphoenixes commented Jul 18, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

Make sure you follow contributing guide English | (中文 | Español | Français).
Make sure you are merging your commits to dev branch.
Add some descriptions and refer to relative issues for your PR.


          feat: add mention component

54b42f8

pull-request-triage bot assigned Fuphoenixes

pull-request-triage bot commented Jul 18, 2024

👋 @Fuphoenixes, thank you for contributing element-plus.

You can comment with /label Components:[component_name] to add a label for which component you are working on.
You may join our for staying tuned.

pull-request-triage bot added the Needs Review label

github-actions bot commented Jul 18, 2024 •

edited

Loading

github-actions bot added the CommitMessage::Qualified label

Contributor Author

Fuphoenixes commented Jul 18, 2024

@element-plus/backers see see

Fuphoenixes requested review from kooriookami and jw-foss

July 18, 2024 09:42

Fuphoenixes added 2 commits

July 18, 2024 17:56


          fix: build error

3a93d0c


          fix: build error

a1c0f6f

github-actions bot commented Jul 18, 2024 •

edited

Loading

🧪 Playground Preview: https://element-plus.run/?pr=17586
Please comment the example via this playground if needed.

Fuphoenixes added 2 commits

July 19, 2024 10:43


          feat: delete as a whole

b28d83b


          fix: update docs

tolking reviewed

View reviewed changes

typings/components.d.ts Show resolved Hide resolved


          fix: update global.d.ts

e6d203d

Member

kooriookami commented Jul 19, 2024

It's a great component!

btea reviewed

View reviewed changes

packages/components/mention/src/helper.ts Outdated Show resolved Hide resolved

packages/components/mention/src/helper.ts Outdated Show resolved Hide resolved

packages/components/mention/src/helper.ts Outdated Show resolved Hide resolved


          fix: update

2ea203a

btea added the Project::New Component label

tolking reviewed

View reviewed changes

docs/en-US/component/mention.md Outdated Show resolved Hide resolved

tolking reviewed

View reviewed changes

Member

tolking left a comment

The position of the dropdown is incorrect when using the prepare slot. Bug

packages/components/mention/src/mention-dropdown.vue Outdated Show resolved Hide resolved

packages/components/mention/src/helper.ts Outdated Show resolved Hide resolved

packages/components/mention/src/helper.ts Show resolved Hide resolved

packages/components/mention/index.ts Outdated Show resolved Hide resolved

tolking added the Minor Version label

Fuphoenixes force-pushed the feat/mention branch from a8cb727 to b0b4bdd Compare

July 26, 2024 10:04


          fix: update code

b18b2c4

Fuphoenixes force-pushed the feat/mention branch from b0b4bdd to b18b2c4 Compare

July 26, 2024 10:06

btea reviewed

View reviewed changes

docs/en-US/component/mention.md Show resolved Hide resolved

btea reviewed

View reviewed changes

packages/components/input/src/input.vue Show resolved Hide resolved

packages/components/mention/src/mention-dropdown.vue Outdated Show resolved Hide resolved

packages/components/mention/src/mention-dropdown.vue Show resolved Hide resolved

packages/components/mention/src/mention.vue Outdated Show resolved Hide resolved

packages/components/mention/src/mention.vue Outdated Show resolved Hide resolved

packages/components/mention/src/mention.vue Outdated Show resolved Hide resolved

Fuphoenixes added 2 commits

July 29, 2024 14:27


          fix: update code

1eefd4d


          fix: update code

c365a18

tolking reviewed

View reviewed changes

packages/components/mention/src/mention.ts Outdated Show resolved Hide resolved

docs/en-US/component/mention.md Outdated Show resolved Hide resolved

packages/components/mention/src/mention.vue Outdated Show resolved Hide resolved

packages/components/mention/src/mention.vue Show resolved Hide resolved


          fix: update code

454e111

btea reviewed

View reviewed changes

docs/en-US/component/mention.md Outdated Show resolved Hide resolved

docs/en-US/component/mention.md Outdated Show resolved Hide resolved

docs/en-US/component/input.md Outdated Show resolved Hide resolved

docs/examples/mention/loading.vue Outdated Show resolved Hide resolved

packages/components/mention/src/mention.ts Show resolved Hide resolved

packages/components/mention/src/mention.ts Show resolved Hide resolved

btea reviewed

View reviewed changes

docs/en-US/component/mention.md Outdated Show resolved Hide resolved


          fix: upload code

c808536

tolking reviewed

View reviewed changes

docs/examples/mention/loading.vue Show resolved Hide resolved


          fix: update code

ffb0e0a

tolking reviewed

View reviewed changes

packages/components/mention/src/mention.vue Outdated Show resolved Hide resolved


          fix: fixed cursor position abnormality

c8d0946

tolking approved these changes

View reviewed changes

btea approved these changes

View reviewed changes


          fix: update code

d0ba6ea

kooriookami mentioned this pull request

chore(components): remove deprecated 2.8.0 #17735

Merged


          fix: docs add avatar

666cf45

kooriookami approved these changes

View reviewed changes

Fuphoenixes added 3 commits

August 1, 2024 18:31


          fix: tooltip position is wrong when placing on top

b46c4b6


          feat: add overview icon

e31aa30


          fix: overview icon color

8c93232

kooriookami approved these changes

View reviewed changes

kooriookami merged commit 0456c79 into dev

9 checks passed

kooriookami deleted the feat/mention branch

August 2, 2024 03:00

tolking pushed a commit that referenced this pull request


          feat: add mention component (#17586)

6adc13c

* feat: add mention component

* fix: build error

* fix: build error

* feat: delete as a whole

* fix: update docs

* fix: update global.d.ts

* fix: update

* fix: update code

* fix: update code

* fix: update code

* fix: rename

* fix: update code

* fix: upload code

* fix: update code

* fix: fixed cursor position abnormality

* fix: update code

* fix: docs add avatar

* fix: tooltip position is wrong when placing on top

* feat: add overview icon

* fix: overview icon color

tolking pushed a commit that referenced this pull request


          feat: add mention component (#17586)

d9ba294

* feat: add mention component

* fix: build error

* fix: build error

* feat: delete as a whole

* fix: update docs

* fix: update global.d.ts

* fix: update

* fix: update code

* fix: update code

* fix: update code

* fix: rename

* fix: update code

* fix: upload code

* fix: update code

* fix: fixed cursor position abnormality

* fix: update code

* fix: docs add avatar

* fix: tooltip position is wrong when placing on top

* feat: add overview icon

* fix: overview icon color

tolking pushed a commit that referenced this pull request


          feat: add mention component (#17586)

69354b4

* feat: add mention component

* fix: build error

* fix: build error

* feat: delete as a whole

* fix: update docs

* fix: update global.d.ts

* fix: update

* fix: update code

* fix: update code

* fix: update code

* fix: rename

* fix: update code

* fix: upload code

* fix: update code

* fix: fixed cursor position abnormality

* fix: update code

* fix: docs add avatar

* fix: tooltip position is wrong when placing on top

* feat: add overview icon

* fix: overview icon color

element-bot mentioned this pull request

Merged

3 tasks

B1u3e mentioned this pull request

[Snyk] Upgrade element-plus from 2.2.12 to 2.8.0 B1u3e/ruoyi#168

Open

lcf262412 mentioned this pull request

[Snyk] Upgrade: dayjs, element-plus, pinia, swiper lcf262412/website#5

Open

This was referenced Sep 25, 2024

[Snyk] Upgrade element-plus from 2.2.12 to 2.8.1 B1u3e/ruoyi#177

Open

[Snyk] Upgrade element-plus from 2.2.12 to 2.8.2 B1u3e/ruoyi#187

Open

B1u3e mentioned this pull request

[Snyk] Upgrade element-plus from 2.2.12 to 2.8.3 B1u3e/ruoyi#191

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CommitMessage::Qualified Minor Version Needs Review Project::New Component