Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [date-picker] type add months params #17342

Merged
merged 5 commits into from
Jul 19, 2024
Merged

feat(components): [date-picker] type add months params #17342

merged 5 commits into from
Jul 19, 2024

Conversation

Panzer-Jack
Copy link
Contributor

@Panzer-Jack Panzer-Jack commented Jun 27, 2024 •
edited
Loading

closes: #17317

新增功能

date-picker 支持 月份 多选 ( element-ui 曾支持此功能 )

使用方式

<el-date-picker
   v-model="value"
   type="months"
/>

演示效果

chrome-capture-2024-6-27 (1)

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @Panzer-Jack, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 27, 2024
@github-actions GitHub Actions
Copy link

Hello @Panzer-Jack, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

@Panzer-Jack Panzer-Jack changed the title feat: feat(components): [date-picker] type add months parmas feat: feat(components): [date-picker] type add months params Jun 27, 2024
@Panzer-Jack Panzer-Jack changed the title feat: feat(components): [date-picker] type add months params feat(components): [date-picker] type add months params Jun 27, 2024
@Panzer-Jack Panzer-Jack force-pushed the feat/date-picker-add-type-month-prop branch from 7b32d2a to 655830e Compare June 27, 2024 08:35
@Panzer-Jack Panzer-Jack mentioned this pull request Jun 27, 2024
Closed
@Panzer-Jack Panzer-Jack force-pushed the feat/date-picker-add-type-month-prop branch 6 times, most recently from 68a971f to f2175ee Compare June 27, 2024 11:16
@Panzer-Jack
Copy link
Contributor Author

Panzer-Jack commented Jun 28, 2024 •
edited
Loading

@btea hello, How can I get the label CommitMessage::Qualified ? Is there something wrong with my commit?

@Panzer-Jack Panzer-Jack force-pushed the feat/date-picker-add-type-month-prop branch from f2175ee to 9106477 Compare June 28, 2024 02:14
@zhixiaotong
Copy link
Contributor

好快，好卷……昨天临时有事，最后一点没写完，今天就看到这个pr了，默默撤回代码（顺便给你点个赞！😊）

@Panzer-Jack
Copy link
Contributor Author

Panzer-Jack commented Jun 28, 2024 •
edited
Loading

好快，好卷……昨天临时有事，最后一点没写完，今天就看到这个pr了，默默撤回代码（顺便给你点个赞！😊）

@zhixiaotong 2333，对了 话说 CommitMessage::Qualified 这个标签如何get到啊

@zhixiaotong
Copy link
Contributor

好快，好卷……昨天临时有事，最后一点没写完，今天就看到这个pr了，默默撤回代码（顺便给你点个赞！😊）

@zhixiaotong 2333，对了 话说 CommitMessage::Qualified 这个标签如何get到啊

你用pnpm cz命令生成提交信息就应该有了，就是提交信息可能哪里少了空格

@Panzer-Jack Panzer-Jack force-pushed the feat/date-picker-add-type-month-prop branch from 9106477 to 1ac321c Compare June 28, 2024 03:00
@Panzer-Jack
Copy link
Contributor Author

好快，好卷……昨天临时有事，最后一点没写完，今天就看到这个pr了，默默撤回代码（顺便给你点个赞！😊）

@zhixiaotong 2333，对了 话说 CommitMessage::Qualified 这个标签如何get到啊

你用pnpm cz命令生成提交信息就应该有了，就是提交信息可能哪里少了空格

@zhixiaotong 试了下 好像还是没有（悲

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=17342
Please comment the example via this playground if needed.

tolking
tolking reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

建议：

  • 增加相关测试
  • 向文档中增加一个示例

@Panzer-Jack
Copy link
Contributor Author

LGTM.

建议：

  • 增加相关测试
  • 向文档中增加一个示例

@tolking done~

btea
btea approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit dbfa93b into element-plus:dev Jul 19, 2024
9 checks passed
@tolking tolking mentioned this pull request Jul 22, 2024
Closed
3 tasks
@element-bot element-bot mentioned this pull request Jul 26, 2024
Merged
3 tasks
@B1u3e B1u3e mentioned this pull request Sep 5, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
@B1u3e B1u3e mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

Assignees

@Panzer-Jack Panzer-Jack

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] el-date-picker支持多选单个年和日期，但是不支持多选单个月份
4 participants
@Panzer-Jack @zhixiaotong @tolking @btea