Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components):[tabs] reactive objects may lose reactivity in label slot #14135

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix(components):[tabs] reactive objects may lose reactivity in label slot #14135

merged 1 commit into from
Jul 30, 2024

Conversation

makedopamine
Copy link
Collaborator

@makedopamine makedopamine commented Aug 28, 2023 •
edited
Loading

@pull-request-triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 28, 2023
@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

🧪 Playground Preview: https://element-plus.run/?pr=14135
Please comment the example via this playground if needed.

@HeftyKoo HeftyKoo requested review from tolking and btea September 20, 2023 06:25
tolking
tolking reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if this could be fixed in other ways

packages/components/tabs/src/tabs.tsx Outdated Show resolved Hide resolved
@makedopamine
Copy link
Collaborator Author

I've committed the new solution, please give me some advice when you are free. Thanks!

@makedopamine makedopamine requested a review from tolking July 29, 2024 13:57
tolking
tolking approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btea btea merged commit f12b020 into element-plus:dev Jul 30, 2024
9 checks passed
tolking pushed a commit that referenced this pull request Aug 2, 2024
@makedopamine @tolking
fix(components):[tabs] reactive objects may lose reactivity in label …
c10514c 
…slot (#14135)
tolking pushed a commit that referenced this pull request Aug 2, 2024
@makedopamine @tolking
fix(components):[tabs] reactive objects may lose reactivity in label …
cb541fd 
…slot (#14135)
tolking pushed a commit that referenced this pull request Aug 2, 2024
@makedopamine @tolking
fix(components):[tabs] reactive objects may lose reactivity in label …
c2bdf77 
…slot (#14135)
@makedopamine makedopamine deleted the fix/tab_slot branch August 6, 2024 06:58
@element-bot element-bot mentioned this pull request Aug 9, 2024
Merged
3 tasks
@B1u3e B1u3e mentioned this pull request Sep 5, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 25, 2024
Open
Open
@B1u3e B1u3e mentioned this pull request Oct 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@tolking tolking tolking approved these changes

@HeftyKoo HeftyKoo HeftyKoo approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [tabs] [tabs] 数据变化后，dom没有更新
4 participants
@makedopamine @HeftyKoo @tolking @btea