Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust & Decoration: Final room header design #25499

Open
americanrefugee opened this issue Jun 1, 2023 · 9 comments
Open

Trust & Decoration: Final room header design #25499

americanrefugee opened this issue Jun 1, 2023 · 9 comments
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement

Comments

@americanrefugee
Copy link

New UX and UI for room headers on Element X Web

@luixxiul
Copy link

luixxiul commented Jun 1, 2023

Are those resources available to the community?

@weeman1337
Copy link
Contributor

@americanrefugee are there any objections to making the Figma files publicly available?

@weeman1337 weeman1337 added S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jun 2, 2023
@americanrefugee
Copy link
Author

americanrefugee commented Jun 2, 2023 via email

@luixxiul
Copy link

luixxiul commented Jun 2, 2023

Thank you. I checked, and it will be major UI update (which seems to be so large that almost any PRs for the current design will be obsolete)

@mxandreas
Copy link

Is this still relevant?

@andybalaam
Copy link
Member

@americanrefugee @florianduros is this done?

@florianduros
Copy link
Member

@andybalaam I'll ask the web team about it, I didn't work on it

@florianduros
Copy link
Member

@andybalaam It's not done, the EW team has worked on the room header but we avoided any areas which dealt with crypto/verification decoration.

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Jan 6, 2025

I think we have a problem here.
From what I can see the legacy room shields icons have been replaced with the new badge design. This is wrong; user identity badges are different from room shields

Legacy shields

image image

New identity badge wrongly used to replace shield

image image

The new badges are different from room shields. And room shields are deprecated with Invisible Crypto.

The verified badges apply only to users, to states that there identity is verified or is in verification violation.
With invisible crypto insecure devices are excluded, so there is no need for a room shield decoration.

We need new tasks to:

  • Remove room shields when Exclusion of insecure device is enabled
  • Properly put the badge on users everywere it applies (profile pic, member ...?)

Also it is inconsistent

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Enhancement
Projects
None yet
Development

No branches or pull requests

7 participants