Fix for preload entrypoint #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes electron-react-boilerplate#2395. I believe that this is a proper fix, and not just a workaround. This probably requires validation from someone more knowledgeable.
|
@murrayju thank you very much for your fix! it helped me in my app as well even though I don't use redux and react-navigation. worked like a charm! will test more but so far so good. |
amilajack
pushed a commit
that referenced
this pull request
Jul 20, 2020
Fixes #2395. I believe that this is a proper fix, and not just a workaround. This probably requires validation from someone more knowledgeable.
Merged
amilajack
added a commit
that referenced
this pull request
Jul 24, 2020
* Fix e2e test error (#2516) * Fix for preload entrypoint (#2503) Fixes #2395. I believe that this is a proper fix, and not just a workaround. This probably requires validation from someone more knowledgeable. * bump deps * update version to 1.3.0, dedupe yarn.lock * fix: dedupe lockfile * fix: run CI tests with xvfb * downgrade electron * dedupe * update lockfile Co-authored-by: Jinseok Jeong <checkitup@hotmail.com> Co-authored-by: Justin Murray <justin@murrayju.com> Co-authored-by: John Tran <jptran318@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2395.
I believe that this is a proper fix, and not just a workaround. This probably requires validation from someone more knowledgeable.