Build pdf component for win-print API support. #104
Conversation
The pdf header files have dependency on ppapi header. To ship pdf, we also need to ship ppapi.
|
@hokein i am wroking on supporting ppapi, glad that you shipped ppapi headers in this patch. But there are a few ppapi components that needs to be built (ppai_*), shall i base it on this PR or you will be adding it ? |
|
@deepak1556 Which ppapi components will you need? The It may require a long time to get win-print patch merged. If you need it eariler, you can directly ship ppapi without basing on this PR, and I will update this PR later. |
|
Ah cool just needed |
| @@ -33,6 +33,7 @@ | |||
| '<(DEPTH)/content/content.gyp:content_app_both', | |||
| '<(DEPTH)/content/content_shell_and_tests.gyp:content_shell_pak', | |||
| '<(DEPTH)/net/net.gyp:net_with_v8', | |||
| '<(DEPTH)/pdf/pdf.gyp:pdf', | |||
There was a problem hiding this comment.
This dependency is only needed on Windows. And pdf.gyp:pdf is hard-coded to be static_library, we have to deal with it specially in component build.
There was a problem hiding this comment.
The component build has been finished now. For pdf.lib static library in component build, we need to link all its dependent libraries manually. Also introducing change on electron-archive/brightray#102.
@zcbenz please take a look.
|
✨ |
Build pdf component for win-print API support.
No description provided.