Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context-menu event with BaseWindows #44953

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Dec 4, 2024

Backport of #44940

See that PR for details.

Notes: Fixed an possible crash when using draggable regions and BaseWindows to get the context-menu event.

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@trop trop bot requested review from codebytere and a team December 4, 2024 21:36
@trop trop bot mentioned this pull request Dec 4, 2024
5 tasks
@trop trop bot added 33-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Dec 4, 2024
@VerteDinde VerteDinde merged commit 4062d18 into 33-x-y Dec 5, 2024
56 checks passed
@VerteDinde VerteDinde deleted the trop/33-x-y-bp-fix-context-menu-event-with-basewindows--1733348139560 branch December 5, 2024 00:03
Copy link

release-clerk bot commented Dec 5, 2024

Release Notes Persisted

Fixed an possible crash when using draggable regions and BaseWindows to get the context-menu event.

@mayfield
Copy link

This change appears to cause duplicate contextmenu events to trigger on macos.

mayfield added a commit to SauceLLC/sauce4zwift that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
33-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants