Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure context-menu emitted for draggable regions #44761

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: ensure context-menu emitted for draggable regions #44761

merged 2 commits into from
Nov 22, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 20, 2024 •
edited
Loading

Description of Change

Closes #44386.
Refs #41256

Fixes an issue where the webContents context-menu event was not emitted when using -webkit-app-region: drag. This was happening after the sibling view change above because sendEvent in NativeWidgetMacNSWindow no longer sent the right-click event to the correct NSView. We can fix this by intercepting the event in sendEvent on ElectronNSWindow, which inherits from NativeWidgetMacNSWindow. This solution avoids patching.

cc @bpasero

Checklist

Release Notes

Notes: Fixed an issue where the webContents context-menu event was not emitted when using -webkit-app-region: drag.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2024
deepak1556
deepak1556 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Nov 22, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 22, 2024
@codebytere codebytere merged commit 86e4529 into main Nov 22, 2024
61 checks passed
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 22, 2024

Release Notes Persisted

Fixed an issue where the webContents context-menu event was not emitted when using -webkit-app-region: drag.

@codebytere codebytere deleted the context-menu-fix branch November 22, 2024 11:33
This was referenced Nov 22, 2024
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Nov 22, 2024

I have automatically backported this PR to "32-x-y", please check out #44798

@trop trop bot added in-flight/32-x-y and removed target/32-x-y PR should also be added to the "32-x-y" branch. labels Nov 22, 2024
@trop
Copy link
Contributor

trop bot commented Nov 22, 2024

I have automatically backported this PR to "34-x-y", please check out #44799

@trop
Copy link
Contributor

trop bot commented Nov 22, 2024

I have automatically backported this PR to "33-x-y", please check out #44800

@trop trop bot added in-flight/34-x-y in-flight/33-x-y and removed target/34-x-y PR should also be added to the "34-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. in-flight/33-x-y labels Nov 22, 2024
@trop trop bot added merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. and removed in-flight/34-x-y in-flight/32-x-y labels Nov 22, 2024
michal-pichlinski-openfin added a commit to michal-pichlinski-openfin/electron that referenced this pull request Nov 25, 2024
@michal-pichlinski-openfin
chore: Removed fix: ensure emitted for draggable regions (electron#44761
6cc355f 
)

It is no longer needed when using `views::WebView`, which fixes
the issue in the `InspectableWebContentsView::OnMousePressed`
by temporarily pretending that the WebContents is fully non-draggable.
@lslzl3000
Copy link

is this issue related to #44887?

This was referenced Dec 2, 2024
Closed
Closed
@nikwen nikwen mentioned this pull request Dec 4, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr left review comments

@deepak1556 deepak1556 deepak1556 approved these changes

@nornagon nornagon Awaiting requested review from nornagon

@MarshallOfSound MarshallOfSound Awaiting requested review from MarshallOfSound

Assignees
No one assigned
Labels
merged/32-x-y PR was merged to the "32-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] unable to get context-menu event when using -webkit-app-region: drag
4 participants
@codebytere @lslzl3000 @ckerr @deepak1556