Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: reland bump Node.js to v22.9.0 #44597

Merged
merged 2 commits into from
Nov 13, 2024
Merged

build: reland bump Node.js to v22.9.0 #44597

merged 2 commits into from
Nov 13, 2024

Conversation

VerteDinde
Copy link
Member

@VerteDinde VerteDinde commented Nov 8, 2024 •
edited
Loading

Description of Change

This reverts commit f9a0401 and relands #44281. This PR is dependent upon unblocking release symbols on macOS.

Note: Thin LTO is stripping the needed symbols out of release builds. Let's favor landing an upgraded Node version in main sooner, and disabling thin LTO as a short term solution. Follow up issue to reland is here: #44632

Checklist

Release Notes

Notes: Upgrades Node to v22.9.0

@VerteDinde VerteDinde added semver/patch backwards-compatible bug fixes no-backport and removed semver/none labels Nov 8, 2024
@MarshallOfSound MarshallOfSound mentioned this pull request Nov 13, 2024
Closed
3 tasks
@VerteDinde VerteDinde mentioned this pull request Nov 13, 2024
Open
@VerteDinde VerteDinde marked this pull request as ready for review November 13, 2024 05:54
@VerteDinde VerteDinde requested review from a team as code owners November 13, 2024 05:55
@codebytere
Copy link
Member

Kicked a publish job on macOS: https://github.com/electron/electron/actions/runs/11817423058

@codebytere
Copy link
Member

Confirmed to build locally with release:

electron on git:reland-node-22 ❯ e build                             2:04PM
Running "autoninja -j 200 electron" in /Users/codebytere/Developer/electron-gn/src/out/Release
Proxy started successfully.
[0/1] Regenerating ninja files
[37413/37414] COPY_BUNDLE_DATA gen/e...g_info Electron.app/Contents/PkgInfo
RBE Stats: down 28.81 GB, up 241.63 MB, 992 racing locals, 34238 racing remotes

@codebytere codebytere merged commit 946ab5f into main Nov 13, 2024
55 of 63 checks passed
@release-clerk Release Clerk
Copy link

release-clerk bot commented Nov 13, 2024

Release Notes Persisted

Upgrades Node to v22.9.0

@codebytere codebytere deleted the reland-node-22 branch November 13, 2024 14:34
@reitowo
Copy link
Contributor

reitowo commented Dec 6, 2024

Which electron version will it land? 34? 35?

I see Electron 33 already dropped support for macOS 10.15, could it possible catch up 34?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
no-backport semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VerteDinde @codebytere @reitowo