Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused ConvertableToTraceFormatWrapper (33-x-y) #43378

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: remove unused ConvertableToTraceFormatWrapper (33-x-y) #43378

merged 1 commit into from
Aug 20, 2024

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Aug 20, 2024

Manual backport of #43356 to 33-x-y. See that PR for details.

Notes: none.

@ckerr
chore: remove unused ConvertableToTraceFormatWrapper (#43356)
069c923 
* chore: remove unused ConvertableToTraceFormatWrapper

Last use removed in Apr 2024 (39bf441, #41880)

* fixup! chore: remove unused ConvertableToTraceFormatWrapper

remove now-unused trace_event.h header, too
@ckerr ckerr added semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 20, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2024
@trop trop bot mentioned this pull request Aug 20, 2024
Merged
3 tasks
@trop trop bot requested a review from a team August 20, 2024 20:03
@trop trop bot added 33-x-y backport This is a backport PR labels Aug 20, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 20, 2024
@ckerr ckerr changed the title chore: remove unused ConvertableToTraceFormatWrapper (#43356) chore: remove unused ConvertableToTraceFormatWrapper (33-x-y) Aug 20, 2024
@ckerr ckerr merged commit 2d24045 into 33-x-y Aug 20, 2024
67 checks passed
@ckerr ckerr deleted the refactor/remove-unused-ConvertableToTraceFormatWrapper--33-x-y branch August 20, 2024 21:53
@release-clerk Release Clerk
Copy link

release-clerk bot commented Aug 20, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Aug 20, 2024

I was unable to backport this PR to "30-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 20, 2024

I was unable to backport this PR to "32-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed target/30-x-y PR should also be added to the "30-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 20, 2024
@trop
Copy link
Contributor

trop bot commented Aug 20, 2024

I was unable to backport this PR to "31-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/31-x-y PR should also be added to the "31-x-y" branch. label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
33-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckerr @jkleinsc