Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accidental handle copying in a range loop #43260

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: accidental handle copying in a range loop #43260

merged 1 commit into from
Aug 9, 2024

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Aug 8, 2024 •
edited
Loading

Description of Change

Fix a wart from e929b21 which used auto instead of auto& in a ranged loop, causing us to create & throw away gin::Handle<MessagePort>s as we loop. Not a major problem; but since we can avoid it, let's avoid it.

Checklist

Release Notes

Notes: none.

@ckerr ckerr added performance 🏁 semver/patch backwards-compatible bug fixes target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 8, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 8, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2024
@ckerr ckerr merged commit c4dfff9 into main Aug 9, 2024
66 checks passed
@ckerr ckerr deleted the fix/range-loop-accidental-copy branch August 9, 2024 18:38
@release-clerk Release Clerk
Copy link

release-clerk bot commented Aug 9, 2024

No Release Notes

This was referenced Aug 9, 2024
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 9, 2024

I have automatically backported this PR to "32-x-y", please check out #43280

@trop trop bot added in-flight/32-x-y and removed target/32-x-y PR should also be added to the "32-x-y" branch. labels Aug 9, 2024
@trop
Copy link
Contributor

trop bot commented Aug 9, 2024

I have automatically backported this PR to "31-x-y", please check out #43281

@trop
Copy link
Contributor

trop bot commented Aug 9, 2024

I have automatically backported this PR to "30-x-y", please check out #43282

@trop trop bot added in-flight/31-x-y in-flight/30-x-y merged/32-x-y PR was merged to the "32-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/32-x-y in-flight/30-x-y labels Aug 9, 2024
@trop trop bot removed the in-flight/31-x-y label Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
merged/30-x-y PR was merged to the "30-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. performance 🏁 semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckerr @deepak1556 @codebytere