chore: avoid crash while notification removal #43040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cucbin
changed the title
codebytere
reviewed
Jul 25, 2024
There was a problem hiding this comment.
@cucbin could you please open a bug report for this, with a reproducible sample, and link it to this PR?
cucbin
changed the title
|
I opened a bug here: #43055 |
codebytere
added
target/30-x-y
codebytere
approved these changes
Jul 26, 2024
|
Release Notes Persisted
|
This was referenced Jul 26, 2024
|
I have automatically backported this PR to "30-x-y", please check out #43059 |
trop
bot
added
in-flight/30-x-y
and removed
target/30-x-y
|
I have automatically backported this PR to "32-x-y", please check out #43060 |
|
I have automatically backported this PR to "31-x-y", please check out #43061 |
trop
bot
added
in-flight/32-x-y
in-flight/31-x-y
merged/31-x-y
trop
bot
added
merged/32-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #43055
Recently, it was discovered that a crash occurs when erasing a notification point object in the
electron::NotificationPresenter::RemoveNotification.Here, it should be checked and additional protection should be added to avoid it.
Checklist
npm testpassesRelease Notes
Notes: Fixes a potential crash when removing notifications on Windows