Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete unused PrintPreviewMessageHandler #41841

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: delete unused PrintPreviewMessageHandler #41841

merged 1 commit into from
Apr 15, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Unused after refactor to headless PDF generation and never deleted.

Checklist

Release Notes

Notes: none

@codebytere codebytere added semver/none target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Apr 12, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 12, 2024
MarshallOfSound
MarshallOfSound approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 13, 2024
@codebytere codebytere added target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. labels Apr 15, 2024
@codebytere codebytere merged commit 2a6ad42 into main Apr 15, 2024
28 of 29 checks passed
@codebytere codebytere deleted the delete-unused-handler branch April 15, 2024 15:34
@release-clerk Release Clerk
Copy link

release-clerk bot commented Apr 15, 2024

No Release Notes

This was referenced Apr 15, 2024
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 15, 2024

I have automatically backported this PR to "30-x-y", please check out #41861

@trop trop bot added in-flight/30-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Apr 15, 2024
@trop
Copy link
Contributor

trop bot commented Apr 15, 2024

I have automatically backported this PR to "29-x-y", please check out #41862

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y in-flight/30-x-y labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. merged/30-x-y PR was merged to the "30-x-y" branch. semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound