Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip the first two invalid updates when SCK is enabled #41340

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: skip the first two invalid updates when SCK is enabled #41340

merged 1 commit into from
Feb 14, 2024

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Feb 14, 2024 •
edited
Loading

Turns out thumbnails come one update later, let's wait a bit

Notes: no-notes

@MarshallOfSound MarshallOfSound added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 14, 2024
@MarshallOfSound MarshallOfSound requested a review from a team as a code owner February 14, 2024 18:20
nornagon
nornagon approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine

@MarshallOfSound MarshallOfSound added the semver/patch backwards-compatible bug fixes label Feb 14, 2024
@MarshallOfSound MarshallOfSound merged commit 7d6a754 into main Feb 14, 2024
16 of 17 checks passed
@MarshallOfSound MarshallOfSound deleted the thumb-cap-v2 branch February 14, 2024 19:56
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 14, 2024

No Release Notes

@trop trop bot mentioned this pull request Feb 14, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Feb 14, 2024

I have automatically backported this PR to "29-x-y", please check out #41344

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @nornagon @VerteDinde