Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note EXIF data unsupported in nativeImage #41261

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

codebytere
Copy link
Member

Description of Change

Closes #41189.

Marks EXIF data as being unsupported in nativeImage. The simple codec functions in Chromium we utilize right now do not take them into account.

Checklist

Release Notes

Notes: none

@codebytere codebytere added documentation 📓 semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. labels Feb 7, 2024
@codebytere codebytere requested review from ckerr, jkleinsc, dsanders11 and a team February 7, 2024 09:57
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 7, 2024
docs/api/native-image.md Outdated Show resolved Hide resolved
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documenting this is a great idea.

👍 on @dsanders11 suggestions. Otherwise LGTM.

Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
@codebytere codebytere requested a review from dsanders11 February 7, 2024 20:36
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 8, 2024
@codebytere codebytere merged commit 8eb580e into main Feb 8, 2024
16 checks passed
@codebytere codebytere deleted the mark-exif-not-supported branch February 8, 2024 13:59
Copy link

release-clerk bot commented Feb 8, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Feb 8, 2024

I have automatically backported this PR to "27-x-y", please check out #41282

@trop trop bot added the in-flight/27-x-y label Feb 8, 2024
@trop trop bot removed the target/27-x-y PR should also be added to the "27-x-y" branch. label Feb 8, 2024
@trop
Copy link
Contributor

trop bot commented Feb 8, 2024

I have automatically backported this PR to "28-x-y", please check out #41283

@trop
Copy link
Contributor

trop bot commented Feb 8, 2024

I have automatically backported this PR to "29-x-y", please check out #41284

@trop trop bot added in-flight/28-x-y in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/27-x-y PR was merged to the "27-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y in-flight/28-x-y in-flight/27-x-y labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. merged/29-x-y PR was merged to the "29-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: nativeImage visually rotates some JPEGs (discards JPEG orientation EXIF metadata)
5 participants