Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated inputFieldType #41239

Merged
merged 1 commit into from
Feb 26, 2024
Merged

chore: remove deprecated inputFieldType #41239

merged 1 commit into from
Feb 26, 2024

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Feb 5, 2024 •
edited
Loading

Description of Change

Follow-up to #40316

Checklist

Release Notes

Notes: The inputFieldType property in the context-menu params has been removed.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 5, 2024
@miniak miniak self-assigned this Feb 6, 2024
@miniak miniak added the wip ⚒ label Feb 6, 2024
ckerr
ckerr requested changes Feb 8, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current changes all LGTM.

The removal probably also deserves a mention in breaking-changes.md, e.g.

Removed: deprecated docs/inputFieldType.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 12, 2024
@miniak
Copy link
Contributor Author

miniak commented Feb 17, 2024

@ckerr definitely, that's why the PR is marked as wip and draft. Formal deprecation needs to happen first however. Doing that in #41362

@miniak miniak force-pushed the miniak/remove-input-field-type branch from 5cd09ed to 5a71584 Compare February 19, 2024 19:10
@miniak miniak requested a review from ckerr February 19, 2024 19:11
@miniak miniak removed the wip ⚒ label Feb 19, 2024
@miniak miniak marked this pull request as ready for review February 19, 2024 19:11
@miniak miniak requested a review from a team as a code owner February 19, 2024 19:11
@electron-cation
Copy link

electron-cation bot commented Feb 19, 2024 •
edited by miniak
Loading

🪦 Deprecation Checklist

🗑️ Previous deprecations being removed in this PR

  • 🏷️ Pull request is labeled as semver/major incompatible API changes
  • 📢 Are called out as removed in docs/breaking-changes.md
  • 📝 Are fully removed from the docs
  • ⌨️ All relevant code is removed
  • 🧪 spec/ts-smoke is updated to use @ts-expect-error for the removed APIs

@electron/wg-releases: Please confirm these deprecation changes conform to our deprecation policies listed in docs/breaking-changes.md, then check the applicable items in the checklist and remove any non-applicable items.

@miniak miniak mentioned this pull request Feb 19, 2024
Closed
5 tasks
@codebytere codebytere changed the title chore: remove deprecated inputFieldType chore: remove deprecated inputFieldType Feb 20, 2024
@miniak
Copy link
Contributor Author

miniak commented Feb 20, 2024

@ckerr the deprecation checklist should be complete now, including updating breaking-changes.md

@codebytere
Copy link
Member

API LGTM

jkleinsc
jkleinsc approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

ckerr
ckerr approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API LGTM

@miniak miniak added target/30-x-y PR should also be added to the "30-x-y" branch. and removed no-backport labels Feb 25, 2024
@jkleinsc jkleinsc merged commit 3885011 into main Feb 26, 2024
32 of 33 checks passed
@jkleinsc jkleinsc deleted the miniak/remove-input-field-type branch February 26, 2024 12:47
@release-clerk Release Clerk
Copy link

release-clerk bot commented Feb 26, 2024

Release Notes Persisted

The inputFieldType property in the context-menu params has been removed.

@trop trop bot mentioned this pull request Feb 26, 2024
Merged
@trop
Copy link
Contributor

trop bot commented Feb 26, 2024

I have automatically backported this PR to "30-x-y", please check out #41440

@trop trop bot added in-flight/30-x-y merged/30-x-y PR was merged to the "30-x-y" branch. and removed target/30-x-y PR should also be added to the "30-x-y" branch. in-flight/30-x-y labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@ckerr ckerr ckerr approved these changes

Assignees

@miniak miniak

Labels
api-review/requested 🗳 deprecation-review/complete ✅ merged/30-x-y PR was merged to the "30-x-y" branch. new-pr 🌱 PR opened in the last 24 hours semver/major incompatible API changes
Projects
Deprecation Board
Status: 🗑 Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @codebytere @ckerr @jkleinsc