docs: document printToPDF generateDocumentOutline option
#41156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
codebytere
requested review from
VerteDinde,
dsanders11,
MarshallOfSound and
a team
codebytere
changed the title
document printToPDF generateDocumentOutline optiondocument printToPDF generateDocumentOutline option
jkleinsc
approved these changes
Jan 29, 2024
erikian
approved these changes
Jan 29, 2024
ckerr
approved these changes
Jan 29, 2024
dsanders11
approved these changes
Jan 29, 2024
|
No Release Notes |
|
I have automatically backported this PR to "29-x-y", please check out #41167 |
trop
bot
added
in-flight/29-x-y
merged/29-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs CL:5026474 & CRBUG:840455
Refs #40523
This new option was added to fix compilation issues in
print_to_pdf::GetPrintPagesParamsbut never documented or otherwise validated/typechecked despite being a valid option. This corrects that issue by adding documentation, typechecking, and an associated test.Checklist
npm testpassesRelease Notes
Notes: none.